Nir Alfasi
Mar 23, 2022

--

Good article - wording matters!

I'd add the following two good practices when doing code review:

1. it's great when the code review can be done together with the writer of the PR: let them walk you through the code changes!

2. when the first option is not feasible, another good practice is to checkout the branch and review the PR on your IDE, ideally run the relevant unit-tests locally, use a debugging tool to go "step by step" and see how to code executes. You'll also get extra points if you'll use a "code coverage" tool (goes well with the "static analysis" section) to see how much coverage the tests have. Important to note that code coverage is only one aspect and it gets less important when the Cyclomatic complexity is high, for example!

--

--

Nir Alfasi
Nir Alfasi

Written by Nir Alfasi

“Java is to JavaScript what Car is to Carpet.” - Chris Heilmann

Responses (1)